Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show features on other map views #1950

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Show features on other map views #1950

merged 4 commits into from
Oct 2, 2023

Conversation

JSunde
Copy link
Contributor

@JSunde JSunde commented Oct 2, 2023

Fixes #1921 1921

@JSunde JSunde requested a review from gino-m October 2, 2023 16:37
@JSunde
Copy link
Contributor Author

JSunde commented Oct 2, 2023

@gino-m PTAL

gino-m
gino-m approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like there are some checks failing.

@JSunde
Copy link
Contributor Author

JSunde commented Oct 2, 2023

Huh... I'm not sure I understand why it's failing. It's saying that it can't resolve lifecycleScope in DropAPinMapFragment, but that isn't something that I added 🤔

@JSunde
Copy link
Contributor Author

JSunde commented Oct 2, 2023

Do you have any ideas @gino-m?

@gino-m
Copy link
Collaborator

gino-m commented Oct 2, 2023

Do you have any ideas @gino-m?

Do tests pass when run locally?

@gino-m
Copy link
Collaborator

gino-m commented Oct 2, 2023

@JSunde lifecycleScope and collect are extension functions which need to be import; it looks like imports may have gotten deleted by the merge.

@gino-m gino-m merged commit c765e70 into master Oct 2, 2023
4 checks passed
@gino-m gino-m deleted the jsunde/1921 branch October 2, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Ground
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show LOIs on map in other map views
2 participants
@JSunde @gino-m