Allow users to delete offline tiles #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o gino-m/1821/offline-area-sizes-1
…o gino-m/1821/offline-area-sizes-1
…' into gino-m/1821/offline-area-sizes-1
shobhitagarwal1612
requested changes
Oct 6, 2023
ground/src/main/java/com/google/android/ground/repository/OfflineAreaRepository.kt
Outdated
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/repository/OfflineAreaRepository.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/google/android/ground/ui/offlineareas/viewer/OfflineAreaViewerViewModel.kt
Show resolved
Hide resolved
ground/src/main/java/com/google/android/ground/util/RangeExt.kt
Outdated
Show resolved
Hide resolved
|
@shobhitagarwal1612 PTAL? |
shobhitagarwal1612
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of offline overlapping areas, only tiles not still in use by other existing offline areas are removed.
Closes #1788
Apologies for slipping this one in just past the code freeze. It was planned but only just got it done now. Thanks!
@hebertlucena FYI
@shobhitagarwal1612 PTAL?
@vittorino This wasn't in the designs, so I improvised based on the previous prototype version. Hope it's ok for now.
Screen_recording_20231005_180639.mp4