Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating anchor point of the progress bar to the correct xml ID #2151

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

justinkimtang
Copy link
Contributor

@justinkimtang justinkimtang commented Jan 3, 2024

Fixes #1975

This updates the reference anchor point for the data collection progress bar. Before this change it was anchored to a non-existent view and so never showed up. Now it is anchored to the correct view.

  • Updated the view Id

Fill out a survey and verify the progress bar is still there.

Screenshot 2024-01-03 at 3 57 21 PM Screenshot 2024-01-03 at 3 57 30 PM

@gino-m PTAL?

@justinkimtang justinkimtang requested a review from gino-m January 3, 2024 21:00
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (250f907) 52.07% compared to head (6bad457) 52.15%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ground/ui/datacollection/DataCollectionFragment.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2151      +/-   ##
============================================
+ Coverage     52.07%   52.15%   +0.08%     
  Complexity     1206     1206              
============================================
  Files           312      312              
  Lines          6122     6122              
  Branches        645      645              
============================================
+ Hits           3188     3193       +5     
+ Misses         2588     2582       -6     
- Partials        346      347       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinkimtang justinkimtang merged commit 59e2143 into master Jan 3, 2024
4 checks passed
@justinkimtang justinkimtang deleted the justinkimtang_progress_bar branch January 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data collection progress indicator appears over tasks
3 participants