Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color of loi card items to white except for in the add loi… #2204

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

justinkimtang
Copy link
Contributor

… case

Fixes #2169

Updates the color of loi_card_item to have a default background color of white. This does not update add_loi_card_item.xml which maintains its greenish tint.

Open a survey and verify that the color of the cards are as expected.

Before:
Screenshot 2024-01-22 at 6 07 35 PM
After:
Screenshot 2024-01-22 at 6 08 06 PM

@gino-m PTAL?

@justinkimtang justinkimtang requested a review from gino-m January 22, 2024 23:14
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎨

@justinkimtang justinkimtang merged commit 72a139c into master Jan 24, 2024
3 of 4 checks passed
@justinkimtang justinkimtang deleted the justinktang_loi_card_color branch January 24, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Job cards] The color of cards doesn't match designs
2 participants