Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch all exception when loading URL for offline tiles. #2270

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

sufyanAbbasi
Copy link
Contributor

@sufyanAbbasi sufyanAbbasi commented Feb 27, 2024

Fixes #2265
Fixes #2234

Catch all exceptions when attempting to load URLs for tiles. Solution also fixes invalid BigTIFF file format!

  • Catching all exceptions and logging when an error occurs.
  • Verified by changing default path locally and triggering the exception.
  • Also hardcoded the BigTiff error and showed that we catch and log that error too.

Logged error message for broken URLs:
Screenshot 2024-02-26 at 11 03 44 PM

Logged error message for bad tiff format:
Screenshot 2024-02-26 at 11 12 51 PM

PTAL @gino-m

@sufyanAbbasi sufyanAbbasi requested a review from gino-m February 27, 2024 07:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 52.41%. Comparing base (9aa4c71) to head (d4e5d1f).
Report is 4 commits behind head on master.

Files Patch % Lines
.../google/android/ground/ui/map/gms/mog/MogClient.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2270      +/-   ##
============================================
- Coverage     52.55%   52.41%   -0.14%     
  Complexity     1222     1222              
============================================
  Files           316      317       +1     
  Lines          6249     6265      +16     
  Branches        659      659              
============================================
  Hits           3284     3284              
- Misses         2602     2618      +16     
  Partials        363      363              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@gino-m gino-m merged commit 3a628cf into master Feb 27, 2024
4 checks passed
@gino-m gino-m deleted the sufy/2265/offline-imagery2 branch February 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants