Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use both task ID and job ID as primary keys and refactor to use $addLoi as the task ID. #2276

Closed
wants to merge 7 commits into from

Conversation

sufyanAbbasi
Copy link
Contributor

Fixes #2275

Removes dependency on the isAddLoiTask field on the task and uses the convention of $addLoi as the marker for LOI tasks. Also reformats all of task local DB and sub tables to use both task_id and job_id as primary keys to prevent conflict.

  • Removes references to isAddLoiTask on the task, instead declares a helper method conveniently called isAddLoiTask().
  • Detect LOI tasks by looking for the $addLoi prefix.
  • Uses both the task ID and job ID to build relationships between task tables in order to prevent task ID conflicts.
  • Created three survey types: adhoc, predefined, and mixed, and verified that each works as intended.

Screenshot 2024-02-28 at 10 08 58 PM

PTAL @gino-m @shobhitagarwal1612

Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composite PKs to the rescue!

@sufyanAbbasi sufyanAbbasi marked this pull request as ready for review February 29, 2024 19:50
@gino-m
Copy link
Collaborator

gino-m commented Mar 1, 2024

The original FR is now obsolete so closing for now. Sorry for the churn!

@gino-m gino-m closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add LOI tasks] Inconsistent behavior of Add LOI tasks
2 participants