Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on startup #2284

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Fix crash on startup #2284

merged 4 commits into from
Mar 1, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Mar 1, 2024

Fixes #2283.

Launches snackbar hint introduced in #2132 in viewLifecycleOwner.lifecycleScope instead of lifecycleScope to ensure coroutine is bound to lifecycle of view. Also, fails gracefully in the rare case there could be a race condition with view destruction.

@gino-m gino-m requested a review from rfontanarosa March 1, 2024 19:49
@gino-m
Copy link
Collaborator Author

gino-m commented Mar 1, 2024

@rfontanarosa PTAL?

@rfontanarosa rfontanarosa merged commit 398ec34 into master Mar 1, 2024
3 of 4 checks passed
@rfontanarosa rfontanarosa deleted the gino-m/2283/fix-startup-crash branch March 1, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App occasionally crashes at startup
2 participants