Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround undismissable snackbar data collection hint by setting to short duration #2288

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Mar 1, 2024

Towards #2286

@scolsen FYI

@gino-m gino-m requested a review from rfontanarosa March 1, 2024 21:53
@rfontanarosa rfontanarosa merged commit 8023b3d into master Mar 1, 2024
3 of 4 checks passed
@rfontanarosa rfontanarosa deleted the gino-m/2286/hide-snackbar-hint branch March 1, 2024 22:04
@scolsen
Copy link
Contributor

scolsen commented Mar 4, 2024

the snackbar should be dismissible by swiping on it--at least this works on a Nexus 5X. Maybe we should debug further? What device did dismisal fail on?

@gino-m
Copy link
Collaborator Author

gino-m commented Mar 4, 2024

the snackbar should be dismissible by swiping on it--at least this works on a Nexus 5X. Maybe we should debug further? What device did dismisal fail on?

Hi @scolsen,. I didn't realize it was swipeable! Don't recall whether I tested on physical Pixel 7 or emu Nexus 5 API 24. Do you have cycles to look into a few small improvements in #2297, #2286, and #2285?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants