Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added null check for Offline LOI #2788

Merged
merged 3 commits into from
Nov 8, 2024

return count fix

9d35999
Select commit
Loading
Failed to load commit list.
Merged

Added null check for Offline LOI #2788

return count fix
9d35999
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2024 in 0s

60.82% (-0.07%) compared to 3005856

View this Pull Request on Codecov

60.82% (-0.07%) compared to 3005856

Details

Codecov Report

Attention: Patch coverage is 21.87500% with 25 lines in your changes missing coverage. Please review.

Project coverage is 60.82%. Comparing base (3005856) to head (9d35999).

Files with missing lines Patch % Lines
.../android/ground/repository/SubmissionRepository.kt 0.00% 15 Missing ⚠️
.../ground/repository/LocationOfInterestRepository.kt 37.50% 2 Missing and 3 partials ⚠️
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 20.00% 4 Missing ⚠️
...round/ui/datacollection/DataCollectionViewModel.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2788      +/-   ##
============================================
- Coverage     60.89%   60.82%   -0.07%     
  Complexity     1162     1162              
============================================
  Files           265      265              
  Lines          6175     6187      +12     
  Branches        859      865       +6     
============================================
+ Hits           3760     3763       +3     
- Misses         1924     1931       +7     
- Partials        491      493       +2     
Files with missing lines Coverage Δ
...round/ui/datacollection/DataCollectionViewModel.kt 71.57% <75.00%> (-0.37%) ⬇️
...ndroid/ground/ui/syncstatus/SyncStatusViewModel.kt 45.45% <20.00%> (-7.18%) ⬇️
.../ground/repository/LocationOfInterestRepository.kt 50.87% <37.50%> (-0.11%) ⬇️
.../android/ground/repository/SubmissionRepository.kt 19.51% <0.00%> (-1.01%) ⬇️