Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Progress Dialog Jetpack Compose Migration #2845

Merged

Conversation

anandwana001
Copy link
Collaborator

@anandwana001 anandwana001 commented Nov 18, 2024

…-compose

# Conflicts:
#	ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/DownloadProgressDialogFragment.kt
#	ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 26 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (f2441dd) to head (dae91b2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ui/offlineareas/selector/DownloadProgressDialog.kt 72.22% 2 Missing and 8 partials ⚠️
...flineareas/selector/OfflineAreaSelectorFragment.kt 47.36% 6 Missing and 4 partials ⚠️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2845      +/-   ##
============================================
- Coverage     61.20%   61.20%   -0.01%     
- Complexity     1183     1185       +2     
============================================
  Files           266      267       +1     
  Lines          6346     6400      +54     
  Branches        903      914      +11     
============================================
+ Hits           3884     3917      +33     
- Misses         1933     1944      +11     
- Partials        529      539      +10     
Files with missing lines Coverage Δ
...lineareas/selector/OfflineAreaSelectorViewModel.kt 25.00% <14.28%> (-2.03%) ⬇️
...ui/offlineareas/selector/DownloadProgressDialog.kt 72.22% <72.22%> (ø)
...flineareas/selector/OfflineAreaSelectorFragment.kt 53.84% <47.36%> (-2.68%) ⬇️

@anandwana001 anandwana001 marked this pull request as ready for review November 28, 2024 04:14
@auto-assign auto-assign bot requested review from gino-m and scolsen November 28, 2024 04:14
@shobhitagarwal1612
Copy link
Member

Please match the UX spec using figma mocks. There are some minor inconsistencies in padding, margin, colors, etc

@shobhitagarwal1612 shobhitagarwal1612 merged commit 20d1540 into master Nov 28, 2024
4 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the anandwana001/2825/download-progress-dialog-compose branch November 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Code health] Migrate DownloadProgressDialog to Compose
3 participants