-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Progress Dialog Jetpack Compose Migration #2845
Merged
shobhitagarwal1612
merged 9 commits into
master
from
anandwana001/2825/download-progress-dialog-compose
Nov 28, 2024
Merged
Download Progress Dialog Jetpack Compose Migration #2845
shobhitagarwal1612
merged 9 commits into
master
from
anandwana001/2825/download-progress-dialog-compose
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-compose # Conflicts: # ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/DownloadProgressDialogFragment.kt # ground/src/main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
============================================
- Coverage 61.20% 61.20% -0.01%
- Complexity 1183 1185 +2
============================================
Files 266 267 +1
Lines 6346 6400 +54
Branches 903 914 +11
============================================
+ Hits 3884 3917 +33
- Misses 1933 1944 +11
- Partials 529 539 +10
|
...d/src/main/java/com/google/android/ground/ui/offlineareas/selector/DownloadProgressDialog.kt
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/google/android/ground/ui/offlineareas/selector/DownloadProgressDialog.kt
Outdated
Show resolved
Hide resolved
Please match the UX spec using figma mocks. There are some minor inconsistencies in padding, margin, colors, etc |
.../main/java/com/google/android/ground/ui/offlineareas/selector/OfflineAreaSelectorFragment.kt
Show resolved
Hide resolved
shobhitagarwal1612
approved these changes
Nov 28, 2024
shobhitagarwal1612
deleted the
anandwana001/2825/download-progress-dialog-compose
branch
November 28, 2024 16:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2825
@shobhitagarwal1612 PTAL?