Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor local LOI persistency renames #2861

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Minor local LOI persistency renames #2861

merged 6 commits into from
Nov 21, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Nov 21, 2024

Towards #2728

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.32%. Comparing base (cc9a990) to head (b8e6830).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../ground/repository/LocationOfInterestRepository.kt 66.66% 1 Missing ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2861   +/-   ##
=========================================
  Coverage     61.31%   61.32%           
  Complexity     1176     1176           
=========================================
  Files           266      266           
  Lines          6331     6330    -1     
  Branches        902      902           
=========================================
  Hits           3882     3882           
+ Misses         1922     1921    -1     
  Partials        527      527           
Files with missing lines Coverage Δ
...oid/ground/persistence/local/room/LocalDatabase.kt 100.00% <ø> (ø)
...d/persistence/local/room/converter/ConverterExt.kt 78.61% <100.00%> (ø)
...ence/local/room/entity/LocationOfInterestEntity.kt 100.00% <100.00%> (ø)
.../persistence/local/room/entity/SubmissionEntity.kt 100.00% <100.00%> (ø)
...rsistence/local/room/fields/EntityDeletionState.kt 100.00% <100.00%> (ø)
...e/local/room/stores/RoomLocationOfInterestStore.kt 78.94% <100.00%> (ø)
...rsistence/local/room/stores/RoomSubmissionStore.kt 59.00% <100.00%> (ø)
.../ground/repository/LocationOfInterestRepository.kt 50.87% <66.66%> (ø)
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 46.47% <0.00%> (+0.64%) ⬆️
---- 🚨 Try these New Features:

@gino-m gino-m merged commit 3a6385f into master Nov 21, 2024
4 checks passed
@gino-m gino-m deleted the gino-m/2728/renames1 branch November 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants