-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Capture location task] Prompted to Correct enable location task #2885
[Capture location task] Prompted to Correct enable location task #2885
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2885 +/- ##
============================================
- Coverage 61.20% 61.19% -0.01%
+ Complexity 1185 1183 -2
============================================
Files 267 267
Lines 6400 6396 -4
Branches 914 914
============================================
- Hits 3917 3914 -3
+ Misses 1944 1943 -1
Partials 539 539
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of moving the code to CaptureLocationTaskFragment, can you do something like:
override fun onResume() {
super.onResume()
if (isVisible) {
// add existing code for showing permission dialog.
}
}
it will not work, because as this fragment is a part of pagination where the code is getting executed when the index is +1. |
We care about the fragment being visible to the user. Can you try out the above code once? |
Tried, not working |
Fixes #2855
@shobhitagarwal1612 PTAL?