[Multiple Choice Task] Fix UI bugs in multiple choice selectors #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
============================================
+ Coverage 62.58% 62.66% +0.07%
Complexity 1203 1203
============================================
Files 267 267
Lines 6356 6358 +2
Branches 877 873 -4
============================================
+ Hits 3978 3984 +6
Misses 1831 1831
+ Partials 547 543 -4
|
gino-m
requested changes
Dec 5, 2024
| android:inputType="text" | ||
| android:text="@{item.otherText}" | ||
| android:textColor="@color/md_theme_onSurface" | ||
| android:textSize="16sp" |
There was a problem hiding this comment.
I believe you'd want to extend Widget.MaterialComponents.TextInputEditText.FilledBox here.
| android:onClickListener="@{() -> viewModel.toggleItem(item)}" | ||
| android:padding="16dp" | ||
| android:text="@{ item.isOtherOption ? @string/other : item.option.label }" | ||
| android:textColor="@color/md_theme_onSurface" | ||
| android:textSize="16sp" |
There was a problem hiding this comment.
Could you define this in styles.xml instead using the Material theme names from Figma here and throughout? I think you need to extend Widget.Material3.CompoundButton.CheckBox.
anandwana001
reviewed
Dec 6, 2024
|
Marking this as draft. Working towards migrating the task's UI to compose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2893
Updates UX as per figma mocks
@gino-m PTAL?