Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Handling for urlConnection #2902

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+42 −13

Merge branch 'master' into anandwana001/2683/prevent-socket-timeout-e…

6b8fa5e
Select commit
Loading
Failed to load commit list.
Open

Error Handling for urlConnection #2902

Merge branch 'master' into anandwana001/2683/prevent-socket-timeout-e…
6b8fa5e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

62.42% (-0.11%) compared to a8cbc36

View this Pull Request on Codecov

62.42% (-0.11%) compared to a8cbc36

Details

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.

Project coverage is 62.42%. Comparing base (a8cbc36) to head (6b8fa5e).

Files with missing lines Patch % Lines
...lineareas/selector/OfflineAreaSelectorViewModel.kt 6.25% 15 Missing ⚠️
...flineareas/selector/OfflineAreaSelectorFragment.kt 50.00% 1 Missing and 4 partials ⚠️
...android/ground/repository/OfflineAreaRepository.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2902      +/-   ##
============================================
- Coverage     62.52%   62.42%   -0.11%     
- Complexity     1203     1204       +1     
============================================
  Files           267      267              
  Lines          6357     6374      +17     
  Branches        881      885       +4     
============================================
+ Hits           3975     3979       +4     
- Misses         1831     1841      +10     
- Partials        551      554       +3
Files with missing lines Coverage Δ
...le/android/ground/ui/map/gms/mog/UrlInputStream.kt 0.00% <ø> (ø)
...android/ground/repository/OfflineAreaRepository.kt 49.18% <0.00%> (ø)
...flineareas/selector/OfflineAreaSelectorFragment.kt 44.64% <50.00%> (-1.20%) ⬇️
...lineareas/selector/OfflineAreaSelectorViewModel.kt 24.41% <6.25%> (-1.56%) ⬇️
View more details on Codecov