-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Play services failures more gracefully #2920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
changed the title
Gino m/2783/report gms install failures
Handle Play services failures more gracefully
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2920 +/- ##
============================================
- Coverage 62.58% 62.52% -0.06%
Complexity 1203 1203
============================================
Files 267 267
Lines 6356 6357 +1
Branches 877 881 +4
============================================
- Hits 3978 3975 -3
Misses 1831 1831
- Partials 547 551 +4
|
…ailures' into gino-m/2783/report-gms-install-failures
anandwana001
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GMS strangeness:
onActivityResult()
is called with a failure result even though the flow is not complete.onActivityResult()
is not called when dismissed.To work around this, if the error is identified as "recoverable, this PR waits indefinitely for Play services to be installed.
Towards #2783 - we may want to follow-up with a PR to add a distinct message "Waiting for Play services..." while waiting.
Filed #2919 as follow-up for edge case.