Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Play services failures more gracefully #2920

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

gino-m
Copy link
Collaborator

@gino-m gino-m commented Dec 11, 2024

Some GMS strangeness:

  • When Play services are present, but disabled, after "ENABLE" is clicked in the resolution dialog, onActivityResult() is called with a failure result even though the flow is not complete.
  • When Play services are not supported on a device, an error dialog is shown, but onActivityResult() is not called when dismissed.

To work around this, if the error is identified as "recoverable, this PR waits indefinitely for Play services to be installed.

Towards #2783 - we may want to follow-up with a PR to add a distinct message "Waiting for Play services..." while waiting.

Filed #2919 as follow-up for edge case.

@gino-m gino-m changed the title Gino m/2783/report gms install failures Handle Play services failures more gracefully Dec 11, 2024
@gino-m gino-m marked this pull request as ready for review December 11, 2024 21:04
@gino-m
Copy link
Collaborator Author

gino-m commented Dec 11, 2024

@anandwana001 @shobhitagarwal1612 PTAL?

@gino-m gino-m removed the request for review from scolsen December 11, 2024 21:07
@gino-m gino-m assigned anandwana001 and unassigned sufyanAbbasi Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.52%. Comparing base (3a1eb7f) to head (5460bc6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...m/google/android/ground/system/GoogleApiManager.kt 41.17% 4 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2920      +/-   ##
============================================
- Coverage     62.58%   62.52%   -0.06%     
  Complexity     1203     1203              
============================================
  Files           267      267              
  Lines          6356     6357       +1     
  Branches        877      881       +4     
============================================
- Hits           3978     3975       -3     
  Misses         1831     1831              
- Partials        547      551       +4     
Files with missing lines Coverage Δ
...m/google/android/ground/system/GoogleApiManager.kt 54.16% <41.17%> (-15.40%) ⬇️

…ailures' into gino-m/2783/report-gms-install-failures
@gino-m gino-m merged commit 9ef90ad into master Dec 12, 2024
4 checks passed
@gino-m gino-m deleted the gino-m/2783/report-gms-install-failures branch December 12, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants