[WIP] Fix Play services install and sign in flow #2924
Draft
+82
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandwana001
approved these changes
Dec 14, 2024
| } else { | ||
| Timber.d(error, "Unknown sign in error") |
There was a problem hiding this comment.
Can we make it Timber.e?
| @@ -69,9 +71,11 @@ constructor( | |||
| override val signInState: Flow<SignInState> = _signInStateFlow.asStateFlow().filterNotNull() | |||
|
|
|||
| override fun initInternal() { | |||
| Timber.d("Listening to Firebase auth state") | |||
There was a problem hiding this comment.
Can we cleanup debug logs if they aren't needed anymore?
| firebaseAuth.addAuthStateListener { auth -> | ||
| Timber.d("Firebase auth state changed") |
|
@shobhitagarwal1612 @anandwana001 This actually won't work - collecting the so-called "MainUiState" on resume will navigate the user away from their current screen in many cases (ToS, survey list, etc), since those screens are not represented in the UiState. Filed #2934 to track, moving back to Draft :/ |
gino-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces ephemeral navigation requests with a "main UI state" which gets applied at start up. This patch resolves existing issues, but there are likely several race conditions lurking due to complexity of the startup/install flow. We should revisit the design on this flow to make it easier to understand and to avoid cancellation exceptions or duplicate side effects (#2923).
Fixes #2919 by restore UI state on on resume.
Fixes #2783