Fix jsonnetfmt --debug-desugaring #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbartholomew
force-pushed
the
debug-desugaring
branch
from
6c6bda0
to
ae6d01f
Compare
sparkprime
reviewed
Feb 8, 2024
sparkprime
approved these changes
Feb 8, 2024
|
Nice |
The desugaring step handles string backslash escape sequences, but it puts the result back into the same AST elements that the input strings came from. When formatting, these strings need to be re-escaped to turn them into printable string literals.
johnbartholomew
force-pushed
the
debug-desugaring
branch
from
ae6d01f
to
5e90d57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desugaring step handles string backslash escape sequences, but it puts the result back into the same AST elements that the input strings came from. When formatting, these strings need to be re-escaped to turn them into printable string literals.