Refresh the instructions for building the docs #1145
Merged
+17
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various minor changes: - gitignore the Jekyll output directory even if you run Jekyll from the repo root. - gitignore the WASM file since it's a build output. - Get rid of tools/scripts/serve_docs.sh - it's no longer needed since Jekyll 4.3.0 which fixed the Content-Type for WASM files (jekyll/jekyll#8965) 4.3.0 was released October 2020. - In push_docs, when checking out the repo to the working directory, directly check out the gh-pages branch instead of checking out HEAD and then switching branch. - Update instructions accordingly.
johnbartholomew
force-pushed
the
update-doc-instructions
branch
from
0b7bcb1
to
c4c7464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor changes:
tools/scripts/serve_docs.sh- it's no longer needed since Jekyll 4.3.0 which fixed the Content-Type for WASM files (Fix response header for content served viajekyll servejekyll/jekyll#8965) 4.3.0 was released October 2020.