-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATE_KOTLIN_VERSION: 1.9.30-dev-2548 #1526
Conversation
@@ -9,7 +9,7 @@ junit5Version=5.8.2 | |||
junitPlatformVersion=1.8.2 | |||
googleTruthVersion=1.1 | |||
|
|||
aaKotlinBaseVersion=1.9.30-dev-1098 | |||
aaKotlinBaseVersion=1.9.30-dev-2548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reword the commit message, so that it can be auto-merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you elaborate? all 3 commits have same commit message, I tried to run the shell command locally and can have all 3 commits filtered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit for AA should be cherry-picked automatically. With UPDATE_KOTLIN_VERSION
in commit message it will be filtered out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately due to the dependency issues in common-util
mentioned in the description, AA commit has to be excluded from auto-merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KSPAATest in the release branch is redundant. Let's disable it.
Talking about tests, we need to enable KSP 2 in gradle tests and integration tests. Could you update CI to include KSP 2.0 in the matrix in a separate PR?
Kotlin: Migrate from ChangedFiles to SourcesChanges
updated commit message for aa version update commit. |
first commit is cherry-picked from #1511 with updated commit message to ensure auto-merge works.
while I separated commits for AA and FE1.0, it is worth mentioning that due to the dependency to the
kotlinBaseVersion
incommon-util
for testing framework, updating AA version alone will cause unit test run time error due to version mismatch in test utils.