Fix ThreadLocal memory leaks in KSObjectCacheManager #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeawc
changed the title
nico-gonzalez
approved these changes
Oct 14, 2024
|
I've been able to validate my fix by building KSP from source against Kotlin dev 5441, building Dagger (Hilt, the Hilt Android Gradle Plugin, and shading lib tools) against that local KSP and Kotlin dev 5441, and then building NowInAndroid against all of those in my local Maven repository. Here are the results observed via VisualVM
|
akiya-nagatsuka
approved these changes
Oct 15, 2024
ZacSweers
approved these changes
Oct 16, 2024
ting-yuan
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #2073, however unable to test against the project that reproduced the issue. I checked the other occurrences of ThreadLocal and the one mentioned in KSObjectCacheManager is the only one which seems it needs specific clearing and is clearly a culprit due to various users providing heap dumps across multiple JDK versions.