Pass entire policy in blackbox_learner #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrofin
changed the title
mtrofin
approved these changes
Sep 13, 2024
boomanaiden154
force-pushed
the
users/boomanaiden154/blackbox-evaluator
branch
from
ea3bb06
to
993b996
Compare
Base automatically changed from
users/boomanaiden154/blackbox-evaluator
to
main
September 16, 2024 22:01
boomanaiden154
force-pushed
the
users/boomanaiden154/serialize-policy-not-bytes
branch
from
de6ed8d
to
ce6a42c
Compare
This patch adjusts blackbox_learner so that it returns an entire policy rather than just the bytes of the policy. When actually running evaluations, we need to writ out the full policy, including the output spec, to disk so the compiler can pick it up. Before this patch, we were not passing along the output spec to the worker.
boomanaiden154
force-pushed
the
users/boomanaiden154/serialize-policy-not-bytes
branch
from
ce6a42c
to
e892b8a
Compare
boomanaiden154
deleted the
users/boomanaiden154/serialize-policy-not-bytes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adjusts blackbox_learner so that it returns an entire policy rather than just the bytes of the policy. When actually running evaluations, we need to write out the full policy, including the output spec, to disk so the compiler can pick it up. Before this patch, we were not passing along the output spec to the worker.