Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of conan dependency to fix Windows build #4851

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

pierricgimmig
Copy link
Collaborator

@pierricgimmig pierricgimmig commented Oct 5, 2023

This fixes the Windows build on mainline, and also ubuntu 20.04 builds.

@pierricgimmig pierricgimmig requested a review from a team as a code owner October 5, 2023 06:47
@pierricgimmig pierricgimmig requested review from danielfenner and removed request for a team October 5, 2023 06:47
Copy link
Collaborator

@beckerhe beckerhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this fixes things - I suspect a bug. But anyway. Great discovery. LGTM.

@pierricgimmig pierricgimmig merged commit 088d4b8 into google:main Oct 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants