Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORBIT_LOG_VAR utility macro #4856

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

pierricgimmig
Copy link
Collaborator

int my_int = 3;
ORBIT_LOG_VAR(my_int);

my_int = 3

This is a quality of life macro for development. We need to specify our own "to_string" as std::to_string does not handle string types.

Copy link
Collaborator

@danielfenner danielfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@florian-kuebler florian-kuebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pierricgimmig
Copy link
Collaborator Author

Merging despite conan issue in the Windows CI which is unrelated to this change:

Error while finding module specification for 'conans.conan' (ModuleNotFoundError: No module named 'conans')

@pierricgimmig pierricgimmig merged commit 3493933 into google:main Oct 19, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants