Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use delta() instead of max() * 2^-bits when delta() is defined #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nghielme
Copy link

@nghielme nghielme commented Oct 25, 2023

I'm working on floating point quantizer and I think this line doesn't work in my case:
delta = self.quantizer.max() * 2**-self.quantizer.bits
With the modification proposed one can define delta() in the quantizer class and use it instead of making the computation in the initializer.

@google-cla
Copy link

google-cla bot commented Oct 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant