Skip to content

Commit

Permalink
Add mention of static feature in README and macos CI job
Browse files Browse the repository at this point in the history
  • Loading branch information
gferon authored and xdev committed Oct 24, 2023
1 parent 1266c67 commit f6f7b83
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,14 @@ jobs:
- uses: actions/checkout@v2
- name: 'Test static-bindgen'
run: 'make static-bindgen'
test-static-linking:
runs-on: ${{ matrix.runs-on }}
strategy:
matrix:
runs-on: [ubuntu-latest, macos-latest]
steps:
- uses: actions/checkout@v2
- if: ${{ matrix.runs-on == "macos-latest" }}
run: make macos-test
- if: ${{ matrix.runs-on == "ubuntu-latest" }}
run: make test
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ docker-test:
${DOCKER_REPO}/${DOCKER_TEST_ENV}:${USED_BUILDENV_VERSION}
.PHONY: docker-test

# Test with the homebrew version of icu4c on macOS with static linking (the default way of linking for distribution on Apple platforms)
macos-test:
brew install icu4c
RUST_ICU_LINK_SEARCH_DIR=$(brew --prefix)/opt/icu4c/lib \
cargo test --no-default-features --features=icu_version_64_plus,icu_version_67_plus,icu_version_68_plus,icu_version_in_env,renaming,static
.PHONY: macos-test

# Refreshes the static bindgen output (contents of ./rust_icu_sys/bindgen) based
# on the currently present ICU versions in the test environment.
#
Expand Down

0 comments on commit f6f7b83

Please sign in to comment.