Link against libc++ on Apple targets #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple systems,
libc++
is the default C++ library1. Trying to compile a binary example usingrust_icu
with thestatic
feature enabled will currently fail on Apple systems with the following error:This patch links against
libc++
on Apple and FreeBSD systems when thestatic
features is enabled.Note: maybe adding a CI job that builds on macOS in
static
mode is also a good idea?Footnotes
https://developer.apple.com/xcode/cpp/ ↩