Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpplint: declare bankruptcy #837

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,11 @@ that apply to that project.
* [TypeScript Style Guide][ts]
* [Vim script Style Guide][vim]

This project also contains [cpplint][cpplint], a tool to assist with style guide
compliance, and [google-c-style.el][emacs], an Emacs settings file for Google
style.
This project also contains [google-c-style.el][emacs], an Emacs settings file
for Google style.

We used to host the [cpplint tool](https://github.com/cpplint/cpplint), but it
Copy link

@tkruse tkruse Aug 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This markup is slightly misleading, it could be read as if Google had hosted the fork at https://github.com/cpplint/cpplint. I would suggest:

We used to host the google internal cpplint tool, but won't be pushing updates.
Open source forks such as [cpplint on PyPi](https://github.com/cpplint/cpplint) exist.

has been forked and an open source community has taken over public maintenance.

If your project requires that you create a new XML document format, the
[XML Document Format Style Guide][xml] may be helpful. In addition to actual
Expand Down Expand Up @@ -85,7 +87,6 @@ primarily optimizing for Google's internal needs.
[angular]: https://google.github.io/styleguide/angularjs-google-style.html
[cl]: https://google.github.io/styleguide/lispguide.xml
[vim]: https://google.github.io/styleguide/vimscriptguide.xml
[cpplint]: https://github.com/google/styleguide/tree/gh-pages/cpplint
[emacs]: https://raw.githubusercontent.com/google/styleguide/gh-pages/google-c-style.el
[xml]: https://google.github.io/styleguide/xmlstyle.html
[dart]: https://www.dartlang.org/guides/language/effective-dart
Expand Down
2 changes: 1 addition & 1 deletion cppguide.html
Original file line number Diff line number Diff line change
Expand Up @@ -2171,7 +2171,7 @@ <h3 id="cpplint">cpplint</h3>
how to run <code>cpplint.py</code> from their project
tools. If the project you are contributing to does not,
you can download
<a href="https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py">
<a href="https://raw.githubusercontent.com/cpplint/cpplint/HEAD/cpplint.py">
<code>cpplint.py</code></a> separately.</p>
</div>

Expand Down
45 changes: 0 additions & 45 deletions cpplint/README

This file was deleted.

Loading