Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update report filtering #1358

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Update report filtering #1358

merged 8 commits into from
Oct 26, 2023

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Oct 5, 2023 •
edited
Loading

Description of the change

  • Adds --priority_filter so we can dynamically change which priorities we want to see full report data for (similar to old turbiniactl implementation).
  • Further reduces the details of things with lower priority so only one line is shown for anything with a low priority
  • Changes the default priority of details shown from "MEDIUM" to "HIGH"
  • Changes --show_all from showing all details for all tasks no matter the priority to showing extra saved path fields for the tasks that are higher priority than the priority filter.
  • Sorts tasks by name in addition to priority and aggregates task summaries with the same exact task status

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

jleaniz
jleaniz approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarontp aarontp marked this pull request as ready for review October 13, 2023 14:45
@aarontp aarontp marked this pull request as draft October 13, 2023 14:46
@aarontp aarontp marked this pull request as ready for review October 25, 2023 22:30
@aarontp
Copy link
Member Author

aarontp commented Oct 25, 2023

@jleaniz PTAL, I changed a couple things since your initial review. Thanks!

@jleaniz
Copy link
Collaborator

jleaniz commented Oct 26, 2023

LGTM x2 - thanks for working on this

@jleaniz jleaniz merged commit ac043cb into google:master Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarontp @jleaniz