Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSH Task and other required states #1368

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix SSH Task and other required states #1368

merged 4 commits into from
Oct 16, 2023

Conversation

aarontp
Copy link
Member

@aarontp aarontp commented Oct 7, 2023 •
edited
Loading

Description of the change

  • Add some required states to a few Tasks. Hoepfully this will fix the errors similar to Task Foo requires Evidence to be in state Bar.
  • Make sure path_specs is defined and errors out properly when it's not set
  • Some automatic editor changes for removing some trailing whitespace.

Applicable issues

Additional information

Checklist

  • All tests were successful.
  • Unit tests added.
  • Documentation updated.

@aarontp aarontp requested a review from jleaniz October 13, 2023 14:45
jleaniz
jleaniz approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@jleaniz jleaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The new evidence states make sense.

@aarontp aarontp merged commit 41f3fac into google:master Oct 16, 2023
5 checks passed
@aarontp aarontp deleted the ssh-analysis-task-fix branch October 16, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleaniz jleaniz jleaniz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarontp @jleaniz