Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force password hash algo #1565

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Don't force password hash algo #1565

merged 1 commit into from
Nov 13, 2024

Conversation

Fryyyyy
Copy link
Collaborator

@Fryyyyy Fryyyyy commented Nov 7, 2024

We assumed the password would always be $6$ but we recently encountered $1$ so let's let Hashcat autodetect

@Fryyyyy
Copy link
Collaborator Author

Fryyyyy commented Nov 7, 2024

Failing test seems unrelated

Copy link
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarontp
Copy link
Member

aarontp commented Nov 13, 2024

Failing test seems unrelated

Yeah, that could be an intermittent failure. Agree it's unrelated so will merge this.

@aarontp aarontp merged commit 799f08b into google:master Nov 13, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants