Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config discovery procedure #156

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

braydonk
Copy link
Collaborator

@braydonk braydonk commented Feb 3, 2024

Config discovery is changing, but it should be non-breaking.

  • The search for a config now starts at the root directory and then searches up the tree to finding the lowest level one. This should help in larger monorepo setups when you want different configs in different places, or to fall back to some default higher in the tree. I am not 100% sure whether this will break some workflows but it will be pretty easy to either change back or provide a short-circuit if necessary.
  • Added a new flag -global_conf that will force the usage of the config from XDG_CONFIG_HOME/LOCALAPPDATA
  • The yamlfmt config can now be in yamlfmt.yaml or yamlfmt.yml instead of just .yamlfmt

Config discovery is changing, but it should be non-breaking.
* The search for a config now starts at the root directory and then
  searches up the tree to finding the lowest level one. This should help
  in larger monorepo setups when you want different configs in different
  places, or to fall back to some default higher in the tree. I am not
  100% sure whether this will break some workflows but it will be pretty
  easy to either change back or provide a short-circuit if necessary.
* Added a new flag `-global_conf` that will force the usage of the
  config from `XDG_CONFIG_HOME`/`LOCALAPPDATA`
* The yamlfmt config can now be in `yamlfmt.yaml` or `yamlfmt.yml`
  instead of just `.yamlfmt`
@braydonk braydonk merged commit be7dd1b into google:main Feb 3, 2024
5 checks passed
@braydonk
Copy link
Collaborator Author

braydonk commented Feb 3, 2024

Forgot to mention this should address #122 and #123 when released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant