-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fill version with git and ldflags #180
Conversation
* Respect goreleaser default except using short hash * Manually set values with git in Makefile as same as goreleaser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! This frees up time for me this release cycle, I appreciate it. 😄
I had two questions, one here in the review and one other I will post, but I'm pretty sure it LGTM!
In the PR description I see that for |
In my understanding, using And current release action is not enabling it. kachick#2
If using
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thank you! |
Suggestion
I want to resolve two things in this PR.
Background
https://github.com/google/yamlfmt/releases/tag/v0.12.1
This is my omitted part in #117 🙇♂️
Example
Before
goreleaser
go build / go install
After
goreleaser
go build / go install