Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix missing targets when using go vet #183

Merged
merged 1 commit into from
May 21, 2024

Conversation

kachick
Copy link
Contributor

@kachick kachick commented May 20, 2024

Currently go vet does not check many files, for example cmd/*.go

> go version
go version go1.22.2 linux/amd64

> go vet -json
# github.com/google/yamlfmt
{}
# github.com/google/yamlfmt_test
# [github.com/google/yamlfmt_test]
{}

> go vet -json ./...
# github.com/google/yamlfmt/internal/collections
{}
# github.com/google/yamlfmt/internal/assert
{}
# github.com/google/yamlfmt/internal/multilinediff
{}
# github.com/google/yamlfmt/internal/logger
{}
# github.com/google/yamlfmt/internal/collections_test
# [github.com/google/yamlfmt/internal/collections_test]
{}
# github.com/google/yamlfmt/internal/tempfile
{}
# github.com/google/yamlfmt/internal/assert_test
# [github.com/google/yamlfmt/internal/assert_test]
{}
# github.com/google/yamlfmt
{}
# github.com/google/yamlfmt/internal/hotfix
{}
# github.com/google/yamlfmt/engine
{}
# github.com/google/yamlfmt_test
# [github.com/google/yamlfmt_test]
{}
# github.com/google/yamlfmt/formatters/basic/anchors
{}
# github.com/google/yamlfmt/formatters/basic/anchors_test
# [github.com/google/yamlfmt/formatters/basic/anchors_test]
{}
# github.com/google/yamlfmt/command
{}
# github.com/google/yamlfmt/formatters/basic
{}
# github.com/google/yamlfmt/formatters/basic_test
# [github.com/google/yamlfmt/formatters/basic_test]
{}
# github.com/google/yamlfmt/cmd/yamlfmt
# [github.com/google/yamlfmt/cmd/yamlfmt]
{}

Copy link
Collaborator

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from another one of my repos, guess I'm doing it wrong there too 😅

Thanks for the fix!

@braydonk braydonk merged commit 629504c into google:main May 21, 2024
7 checks passed
@kachick
Copy link
Contributor Author

kachick commented May 21, 2024

Thank you for merging!

@kachick kachick deleted the fix-go-vet-missing-paths branch May 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants