-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce a json schema file for yamlfmt #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you for adding this!
After this is merged, the follow up is to add it to https://schemastore.org/. I am happy to do it as well once I have time. |
I do not know anything about JSON Schema, so if you know what needs to happen please go ahead. 😄 |
Don't be so happy. Now, you will have to maintain it 😬😅😂 Maybe, you should add a CI step to validate yamlfmt files against this schema |
Well if we're being specific, I don't have to maintain it. But as with anything that makes it to the repo I will try my best to keep it correct and up to date. In general if I add any new configuration values I will try to keep the schema up to date, and have any community contributions that add fields do the same. |
I appreciate your message, it's clear. Thanks |
Indeed. Don't feel any obligation to maintain it, but it should be relatively easy to add new entries should new config keys be added. Feel free to add me as a reviewer if you would like. The CI idea is also good. I don't want to promise because my time is also limited, but if I get spare cycles I'll look into it as well. :) |
Docs:
Issue #181