🐛 panic against empty file with eof_newline feature, resolves: #196 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
approved these changes
Jul 17, 2024
|
Hey @braydonk would you mind releasing this as v0.13.1? I'm using this from pre-commit (which pinned to a tag), and am running into this |
|
Hi @zevisert, I will be cutting a release tomorrow. Sorry for the long turnaround time on this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #196.
YAMLfmt throws panic when linting an empty file with eof_newline feature on.
The problem is that
eofNewlineFeaturehas out-of-range access whencontentis empty.This PR fixes it and handles case when
contentis empty.