Update handling of exceptions in unary_unary interceptors (#27)

* Separate google-api-core and grpcio deps in order to pin grpcio * Update flow of ExceptionInterceptor.intercept_unary_unary method to put logic preceding the try/catch into an else block. * Update LoggingInterceptor.intercept_unary_unary to more safely parse information from response/exception objects.
googleads · Feb 1, 2019 · 0c129e5 · 0c129e5
1 parent 7f6fb9d
commit 0c129e5
Show file tree

Hide file tree

Showing 5 changed files with 750 additions and 201 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,8 @@
 * 0.7.0:
 - Google Ads v0_7 release.
+- Address inconsistent exception handling in Exception and Logging
+interceptors.
+- Pin `google-api-core` and `grpcio` dependencies.
 
 * 0.6.0:
 - Add configurable logging functionality.

diff --git a/google/ads/google_ads/__init__.py b/google/ads/google_ads/__init__.py
@@ -19,4 +19,5 @@
 import google.ads.google_ads.client
 import google.ads.google_ads.errors
 
+
 VERSION = '0.7.0'
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,4 +19,5 @@
		import google.ads.google_ads.client
		import google.ads.google_ads.errors


		VERSION = '0.7.0'