Skip to content

Commit

Permalink
Changes for release v11_1. (#691)
Browse files Browse the repository at this point in the history
  • Loading branch information
BenRKarl authored Aug 22, 2022
1 parent ec7664c commit 6b908c0
Show file tree
Hide file tree
Showing 275 changed files with 3,202 additions and 3,965 deletions.
8 changes: 8 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
* 18.1.0
- Google Ads API v11_1 release.
- Bump protobuf dependency to version 4.21.5.
- Bump proto-plus dependency to version 1.22.0.
- Update examples to remove references to expanded text ads.
- Fix bug preventing https protocol in proxy URLs.
- Various example updates.

* 18.0.0
- Remove support for Google Ads API v9.
- Added "pb" user agent key/value pair.
Expand Down
4 changes: 2 additions & 2 deletions examples/account_management/approve_merchant_center_link.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def main(client, customer_id, merchant_center_account_id):
== merchant_center_link_status_enum.PENDING
and str(merchant_center_link.id) == merchant_center_account_id
):
_update_merchant_center_link_status(
update_merchant_center_link_status(
client,
customer_id,
merchant_center_link_service,
Expand All @@ -81,7 +81,7 @@ def main(client, customer_id, merchant_center_account_id):


# [START approve_merchant_center_link_2]
def _update_merchant_center_link_status(
def update_merchant_center_link_status(
client,
customer_id,
merchant_center_link_service,
Expand Down
6 changes: 3 additions & 3 deletions examples/account_management/get_account_hierarchy.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def main(client, login_customer_id=None):
"The hierarchy of customer ID "
f"{root_customer_client.id} is printed below:"
)
_print_account_hierarchy(
print_account_hierarchy(
root_customer_client, customer_ids_to_child_accounts, 0
)
else:
Expand All @@ -144,7 +144,7 @@ def main(client, login_customer_id=None):
)


def _print_account_hierarchy(
def print_account_hierarchy(
customer_client, customer_ids_to_child_accounts, depth
):
"""Prints the specified account's hierarchy using recursion.
Expand All @@ -171,7 +171,7 @@ def _print_account_hierarchy(
# Recursively call this function for all child accounts of customer_client.
if customer_id in customer_ids_to_child_accounts:
for child_account in customer_ids_to_child_accounts[customer_id]:
_print_account_hierarchy(
print_account_hierarchy(
child_account, customer_ids_to_child_accounts, depth + 1
)

Expand Down
2 changes: 1 addition & 1 deletion examples/account_management/link_manager_to_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def main(client, customer_id, manager_customer_id):
for row in response.result:
manager_link_id = row.customer_client_link.manager_link_id
except GoogleAdsException as ex:
_handle_googleads_exception(ex)
handle_googleads_exception(ex)

customer_manager_link_service = client.get_service(
"CustomerManagerLinkService"
Expand Down
4 changes: 2 additions & 2 deletions examples/account_management/reject_merchant_center_link.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def main(client, customer_id, merchant_center_account_id):
if merchant_center_link.id == merchant_center_account_id:
# A Merchant Center link can be pending or enabled; in both
# cases, we reject it by removing the link.
_remove_merchant_center_link(
remove_merchant_center_link(
client,
merchant_center_link_service,
customer_id,
Expand All @@ -99,7 +99,7 @@ def main(client, customer_id, merchant_center_account_id):


# [START reject_merchant_center_link]
def _remove_merchant_center_link(
def remove_merchant_center_link(
client, merchant_center_link_service, customer_id, merchant_center_link
):
"""Removes a Merchant Center link from a Google Ads client customer account.
Expand Down
8 changes: 4 additions & 4 deletions examples/account_management/update_user_access.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ def main(client, customer_id, email_address, access_role):
access_role: The updated access role.
"""

user_id = _get_user_access(client, customer_id, email_address)
user_id = get_user_access(client, customer_id, email_address)

if user_id:
_modify_user_access(client, customer_id, user_id, access_role)
modify_user_access(client, customer_id, user_id, access_role)


def _get_user_access(client, customer_id, email_address):
def get_user_access(client, customer_id, email_address):
"""Gets the customer user access given an email address.
Args:
Expand Down Expand Up @@ -98,7 +98,7 @@ def _get_user_access(client, customer_id, email_address):
return None


def _modify_user_access(client, customer_id, user_id, access_role):
def modify_user_access(client, customer_id, user_id, access_role):
"""Modifies the user access role to a specified value.
Args:
Expand Down
Loading

0 comments on commit 6b908c0

Please sign in to comment.