-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Client-Side CAB token generation. #1598
base: client-side-cab
Are you sure you want to change the base?
Conversation
14715a8
to
c9af3ff
Compare
String intermediaryToken, sessionKey; | ||
Date intermediaryTokenExpirationTime; | ||
|
||
synchronized (this) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a synchronized block here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the value is written in a synchronized block:
Lines 298 to 307 in 0d96dcf
synchronized (refreshLock) { | |
try { | |
this.intermediateCredentials = Futures.getDone(finishedTask); | |
} finally { | |
if (this.refreshTask != null && this.refreshTask.task == finishedTask) { | |
this.refreshTask = null; | |
} | |
} | |
} | |
} |
I'll update my code to use the refreshLock
and the IntermediateCredentials
wrapper.
699342c
to
2bd4316
Compare
Change-Id: I2c217656584cf5805297f02340cbbabca471f609
2bd4316
to
855a2cc
Compare
Implement Client-Side CAB token generation.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.