fix: update urllib3 to >= 2.0.5 #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
approved these changes
Sep 26, 2023
|
Just a heads up, this is going to cause a lot of pain -- some major packages (for example, botocore) in the python ecosystem require An example of this is |
|
@danmoz thank you for the heads up, I will fix it asap. |
|
problem is fixed in release 2.23.2, #1391 |
hauntsaninja
added a commit
to hauntsaninja/python
that referenced
this pull request
Oct 4, 2023
This was added in kubernetes-client@27459d5. Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389 (I'm also not sure that I follow the logic in kubernetes-client#2105, since dependency resolvers will be able to work it out)
dirrao
pushed a commit
to dirrao/python
that referenced
this pull request
Nov 28, 2023
This was added in kubernetes-client@27459d5. Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389 (I'm also not sure that I follow the logic in kubernetes-client#2105, since dependency resolvers will be able to work it out)
bh717
pushed a commit
to bh717/python-dapp
that referenced
this pull request
Apr 1, 2024
This was added in kubernetes-client/python@27459d5. Note that google-auth now requires urllib3>=2 in googleapis/google-auth-library-python#1389 (I'm also not sure that I follow the logic in kubernetes-client/python#2105, since dependency resolvers will be able to work it out)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1365
urllib3 added back the pyopenssl support and removed the depreciation warning since 2.0.5, so we can upgrade the urllib3 dependency version now.
urllib3 made
RequestMethodsclass private since 2.0.0 (changed fromurllib3.request.RequestMethodstourllib3._request_methods.RequestMethods). We could copy the whole class and the related code into google-auth, but that would be a lot of code, so we let AuthorizedHttp inherit the private class instead, which seems to be the best solution so far.