docs: remove references to ADC environment variable #14914
Merged
+327
−2,699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
commented
Dec 28, 2024
| [spanner roles][spanner-roles-link] to chose a role for this account, the | ||
| principal used to run these benchmark should have (at least) the permissions | ||
| granted by the `roles/spanner.databaseAdmin` role. | ||
| Examine the [spanner roles][spanner-roles-link] to chose a role for the |
There was a problem hiding this comment.
This one merits more attention.
| `universe_domain` field, that value is used to determine service endpoints. If | ||
| the `universe_domain` field is not present, the default value of | ||
| `googleapis.com` is used. | ||
| [Authentication Overview][authentication-quickstart]. |
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14914 +/- ##
==========================================
- Coverage 92.91% 92.91% -0.01%
==========================================
Files 2351 2351
Lines 209702 209702
==========================================
- Hits 194846 194844 -2
- Misses 14856 14858 +2 ☔ View full report in Codecov by Sentry. |
|
PTAL |
|
/gcbrun |
coryan
changed the title
piaxc
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Can you also change the link target for authentication-quickstart to https://cloud.google.com/docs/authentication/
Thanks for doing this!
Done.
No worries. |
|
/gcbrun |
|
PTAL |
|
/gcbrun |
coryan
deleted the
docs-remove-references-to-ADC-environment-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is