feat(storage): add MoveObject functionality to JSON and gRPC #14936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14936 +/- ##
========================================
Coverage 92.91% 92.91%
========================================
Files 2351 2351
Lines 209823 210072 +249
========================================
+ Hits 194949 195194 +245
- Misses 14874 14878 +4 ☔ View full report in Codecov by Sentry. |
bajajneha27
approved these changes
Jan 15, 2025
| std::string source_object_name, | ||
| std::string destination_object_name, | ||
| Options&&... options) { | ||
| google::cloud::internal::OptionsSpan const span( |
There was a problem hiding this comment.
qq: why do we need it here?
scotthart
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Reviewed 30 of 31 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddelgrosso1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is