impl(bigquery): Fixed jobs and tables response for empty use case #14938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14938 +/- ##
==========================================
- Coverage 92.91% 92.90% -0.01%
==========================================
Files 2351 2351
Lines 209823 209833 +10
==========================================
+ Hits 194949 194953 +4
- Misses 14874 14880 +6 ☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the jobs and tables response for the usecase when no jobs or tables returned from the server for the calling account.
Before the fix, the API response for
jobs.listandtables.listassumed that the "jobs" and "tables" json keys will always be provided by the server. From our testing this was not the case.This PR fixes the above and adds unit test cases.
This change is