Skip to content

Commit

Permalink
feat(storage): allow non default service account (#11137)
Browse files Browse the repository at this point in the history
* test(storage): re-enable DetectDirectConnectivity integration test

* feat(storage): allow non default service account
  • Loading branch information
frankyn authored Nov 15, 2024
1 parent d4cacde commit 19f01c3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 4 additions & 1 deletion storage/grpc_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ func defaultGRPCOptions() []option.ClientOption {
)
} else {
// Only enable DirectPath when the emulator is not being targeted.
defaults = append(defaults, internaloption.EnableDirectPath(true), internaloption.EnableDirectPathXds())
defaults = append(defaults,
internaloption.EnableDirectPath(true),
internaloption.EnableDirectPathXds(),
internaloption.AllowNonDefaultServiceAccount(true))
}

return defaults
Expand Down
1 change: 0 additions & 1 deletion storage/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@ var readCases = []readCase{
}

func TestIntegration_DetectDirectConnectivity(t *testing.T) {
t.Skip("direct connectivity not yet available for CI")
ctx := skipHTTP("direct connectivity isn't available for json")
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
h := testHelper{t}
Expand Down

0 comments on commit 19f01c3

Please sign in to comment.