fix(bigquery): do not override ctx within inner span creation #11119
+47
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
alvarowolfx
changed the title
shollyman
approved these changes
Nov 14, 2024
alvarowolfx
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating child spans (mostly inside
runWithRetryfunc), parentcontext.Contextwas being override by the child spancontext.Context, making the parent span to be missing on traces. This PR changes thectxassignment inside thoserunWithRetryto always create a newcontext.Contextjust for that child span, similar to how it was done in other places likegoogle-cloud-go/bigquery/job.go
Line 248 in cc88fe1
Fixes #10961