Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub/v2): rename data plane clients #11376

Open
wants to merge 8 commits into
base: pubsub-v2-trunk
Choose a base branch
from
Open

feat(pubsub/v2): rename data plane clients #11376

wants to merge 8 commits into from

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Jan 6, 2025 •
edited
Loading

Part of #11368

This PR makes the following changes:

  • Rename Topic/Subscription to Publisher/Subscriber (no file name changes)
    • Fix documentation in doc.go
  • Remove TopicInProject, SubscriptionInProject fields

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 6, 2025
@hongalex hongalex mentioned this pull request Jan 6, 2025
Open
21 tasks
@hongalex hongalex force-pushed the pubsub-v2-data-plane-renaming branch from 65af461 to af6fd37 Compare January 7, 2025 21:05
@hongalex hongalex force-pushed the pubsub-v2-data-plane-renaming branch from 4f9d8b1 to 631e1ee Compare January 9, 2025 23:57
@hongalex hongalex marked this pull request as ready for review January 10, 2025 01:06
@hongalex hongalex requested review from shollyman and a team as code owners January 10, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hongalex