Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add integration test for universe domain #27384

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

shubhangi-google
Copy link
Contributor

Adding integration tests for Universe Domain feature
these tests will run with test project credentials

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 30, 2024
@shubhangi-google shubhangi-google changed the title feat(storage):add integration test for universe domain feat(storage): add integration test for universe domain Sep 30, 2024
@bajajneha27
Copy link
Contributor

@shubhangi-google the acceptance test is failing, can you please check?

@shubhangi-google
Copy link
Contributor Author

@shubhangi-google the acceptance test is failing, can you please check?

hi @bajajneha27
earlier kokoro was failing with a test failure now after resubmitting the PR
it is failing with- There was insufficient space
https://btx.cloud.google.com/invocations/10d0b291-1669-48fb-9bc6-fa5037342fc2/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-ruby%2Fpresubmit%2Facceptance/log

please suggest how to proceed

@bajajneha27
Copy link
Contributor

The integration test is still failing. Can you please check?

@shubhangi-google
Copy link
Contributor Author

shubhangi-google commented Sep 30, 2024

Hi @JesseLovelace
Need your suggestions for following

  1. Please suggest the best way to set system environment variables. I’ve attempted to include the export script to set the environment variables in integration.sh, but the Kokoro tests are not picking them up, leading to test failures. As a workaround, I’ve been executing the bash script in the code to set the environment variables.

  2. There’s an issue with the test that checks the bucket location—it’s consistently getting nil for the TEST_UNIVERSE_LOCATION environment variable, causing the check to fail. For now, I’ve removed the check to avoid blocking the tests.

Could you please guide me on how to address these issues?

@danielduhh
Copy link

@dazuma do you have a preference in how the secrets are handled for Ruby?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants