Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development build v1.11.0.dev2 #1025

Closed
wants to merge 55 commits into from
Closed

Development build v1.11.0.dev2 #1025

wants to merge 55 commits into from

Conversation

chalmerlowe
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

sharoonthomas and others added 30 commits November 7, 2023 15:07
@sharoonthomas
feat!: Support SQLAlchemy 2.0, drop support for 1.x
ffc491f 
This patch makes this library backward incompatible for
versions of SQLAlchemy < 2.0.

Fixes #510
@nayaknishant
Merge branch 'main' into sqla2
c7f2751
@nayaknishant
constraints updated
c74a0b9
@gcf-owl-bot @nayaknishant
🦉 Updates from OwlBot post-processor
001759e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@nayaknishant
fixing README.rst
bc5725f
@nayaknishant
fixing README.rst
8d5c2cc
@nayaknishant
upping sqlalchemy version in constraints-3.8.txt
4a355c4
@nayaknishant
adding 2.0 version restrictions to owlbot.py
0079d11
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
89ea48e 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@nayaknishant
fix for
39b0d66
@kiraksi
Updated some compliance tests for sqla2 and bq
1e81318
@kiraksi
Addressed snippet errors
eeffbe6
@kiraksi
revert bad commit
02921c2
@kiraksi
More compliance tests checking
1e9a72e
@kiraksi
reformatted with black
a84af4b
@kiraksi
Changed more compliance tests, updated requirements for testing
c09a676
@chalmerlowe
Merge remote-tracking branch 'origin' into sqla2
6999f62
@kiraksi
Fixed attributeerror in failing sample test
00274e0
@kiraksi
Fixed geolography test failing issue
cb34e6b
@chalmerlowe
Minor tweaks to tests and code
08d93b0
@chalmerlowe
Merge branch 'main' of github.com:googleapis/python-bigquery-sqlalche…
a377a31 
…my into sqla2
@chalmerlowe
Merge branch 'sqla2' into sqla2
2492a0c
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
4a5c291 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@kiraksi
Fixed small error in compliance tests, added pip freeze for owl bot t…
c4c9976 
…esting
@kiraksi
merged from branch
60735ff
@kiraksi
Fixed some failing compliance tests by reformatting
2612a70
@kiraksi
Added UuidTest to compliance tests
5d3d850
@kiraksi
merged main branch
a708987
@kiraksi
Moved back sqlalchemy constraints to 1.4
a3a4ee6
@tswast
Update testing/constraints-3.8.txt
a71e1ee
kiraksi and others added 25 commits December 18, 2023 13:49
@kiraksi
Fixed minimum version of sqlalchemy for 1.4 backwards compatibility
708ec59
@kiraksi
Bumping support for sqlalchemy 1.4.16 for sample tests
9a9bc6b
@kiraksi
Bump setup.py sqlalchemy to 1.4.16
740bfcd
@kiraksi
Updated compliance sqlalchemy to 1.4.16
75038b0
@chalmerlowe
Merge branch 'main' into sqla2
3c50f7d
@kiraksi
Fixed broken code in last merged main, as we need to avoid duplicate …
455dbeb 
…entries and potential implicit joins due to identical table names
@kiraksi
modified tests for join order variation in 1.4 vs 2.0
da9f228
@kiraksi
typo
59f0a4e
@kiraksi
Modified one compliance StringTest thats been flaky
9e8d4e7
@kiraksi
Merge branch 'main' into sqla2
c0016ee
@kiraksi
Updated docs
5503877
@kiraksi
minor fixes to noxfile and README
b4010e1
@chalmerlowe
Merge branch 'main' into sqla2
07a1e65
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
1e54e77 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@kiraksi
cleaned up code from review, removed unnecessary code and files
e95aee1
@chalmerlowe
Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py
b8f8f21
@kiraksi
Merge branch 'main' into sqla2
03fb7f7
@kiraksi
create development release 1.11.0.dev0 branch
dcc89f7
@kiraksi @sharoonthomas
chore: cleanup compliance tests for sqlalchemy migration (#1013)
67cb7bd 
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* chore: cleanup compliance file tests after migration

* lint

* fixed small import error

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>
@kiraksi
Revert "chore: cleanup compliance tests for sqlalchemy migration" (#1015
f3cb2d1 
)
@kiraksi @sharoonthomas
chore: fix coverage tests sqlalchemy 2.0 migration (#987)
19d9ce2 
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>
@kiraksi @sharoonthomas
chore: sqlalchemy test compliance suite cleanup (#1018)
59408a5 
* chore: remove code for sqlalchemy before 1_4

* reformatted with black:

* Removed sqlalchemy compliance tests from versions before 1.4

* removed code in base.py for sqlalchemy < 1.4

* fix coverage issues in base.py

* temporarily commented out code lines not passing coverage for testing purposes

* replaced functions previously removed for not passing cover

* testing removing functions for coverage

* add no cover tag to untested code and clean up commented out functions

* fix lint issues

* black

* Readded deleted tests and renamed them from deprecated names

* black

* chore: sqlalchemy test compliance suite cleanup code

* black

* black

---------

Co-authored-by: Sharoon Thomas <sharoon.thomas@fulfil.io>
@kiraksi
create development release 1.11.0.dev1 branch
1bbf9eb
@kiraksi
create development release 1.11.0.dev2
0c4cf07
@chalmerlowe
test: editing compliance testing to evaluate speedups
a96e3d1
@chalmerlowe chalmerlowe closed this Feb 6, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chalmerlowe @sharoonthomas @nayaknishant @kiraksi @tswast