feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x #1053

tswast · 2024-04-02T20:27:48Z

BEGIN_COMMIT_OVERRIDE
feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x (#920, #1053)

fix: fix grouping sets, rollup and cube rendering issue (#1019, #1053)
END_COMMIT_OVERRIDE

Opening per internal issue 315888151 to get @kiraksi's changes into main now that they've been validated in prereleases.

🦕

This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0. Fixes #510

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…my into sqla2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…esting

tswast · 2024-04-02T20:31:38Z

CHANGELOG.md

@@ -13,6 +13,30 @@ Older versions of this project were distributed as [pybigquery][0].

 [2]: https://pypi.org/project/pybigquery/#history

+## [1.11.0.dev3](https://github.com/googleapis/python-bigquery-sqlalchemy/compare/v1.9.0...v1.11.0.dev3) (2024-02-20)


We should update this to be footers of the commit message, per: https://github.com/googleapis/release-please/blob/main/README.md#what-if-my-pr-contains-multiple-fixes-or-features

README.rst

tswast · 2024-04-02T20:37:45Z

noxfile.py

@@ -369,7 +369,7 @@ def compliance(session):
        session.skip("Compliance tests were not found")

    session.install("--pre", "grpcio")
-    session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy<2.0.0")
+    session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16,<2.1")


2.1 isn't out yet. Let's delete the max version, especially here in prerelease tests, so we get a heads up if we do end up being incompatible with it.

chalmerlowe

Minor tweak to comment

tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

chalmerlowe · 2024-04-03T15:03:23Z

noxfile.py

@@ -369,7 +369,7 @@ def compliance(session):
        session.skip("Compliance tests were not found")

    session.install("--pre", "grpcio")
-    session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy<2.0.0")
+    session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16,<2.1")


Suggested change

session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16,<2.1")

session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16")

Fixed in dfbfcc3

I don't think we need to be installing prerelease versions in compliance session at all.

chalmerlowe · 2024-04-03T15:03:51Z

noxfile.py

@@ -543,7 +543,7 @@ def prerelease_deps(session):

    prerel_deps = [
        "protobuf",
-        "sqlalchemy<2.0.0",
+        "sqlalchemy>=1.4.16,<2.1",


Suggested change

"sqlalchemy>=1.4.16,<2.1",

"sqlalchemy>=1.4.16",

Fixed in dfbfcc3

I don't think we need the >= part since this will install the latest compatible version.

chalmerlowe

minor tweaks.

chalmerlowe · 2024-04-03T16:43:14Z

The failing check (Kokoro SQLAlchemy compliance) has a single failing test that swaps the order of values in the result versus what is expected.
Interestingly, this only happens on github. It does not happen locally.

AssertionError: ['BC', 'AB'] != ['AB', 'BC']

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chalmerlowe

LGTM

…to 1.4.x (googleapis#1053)" This reverts commit 7a4c3c2.

sharoonthomas and others added 30 commits November 7, 2023 15:07

feat!: Support SQLAlchemy 2.0, drop support for 1.x

ffc491f

This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0. Fixes #510

Merge branch 'main' into sqla2

c7f2751

constraints updated

c74a0b9

🦉 Updates from OwlBot post-processor

001759e

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fixing README.rst

bc5725f

fixing README.rst

8d5c2cc

upping sqlalchemy version in constraints-3.8.txt

4a355c4

adding 2.0 version restrictions to owlbot.py

0079d11

🦉 Updates from OwlBot post-processor

89ea48e

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix for

39b0d66

Updated some compliance tests for sqla2 and bq

1e81318

Addressed snippet errors

eeffbe6

revert bad commit

02921c2

More compliance tests checking

1e9a72e

reformatted with black

a84af4b

Changed more compliance tests, updated requirements for testing

c09a676

Merge remote-tracking branch 'origin' into sqla2

6999f62

Fixed attributeerror in failing sample test

00274e0

Fixed geolography test failing issue

cb34e6b

Minor tweaks to tests and code

08d93b0

Merge branch 'main' of github.com:googleapis/python-bigquery-sqlalche…

a377a31

…my into sqla2

Merge branch 'sqla2' into sqla2

2492a0c

🦉 Updates from OwlBot post-processor

4a5c291

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Fixed small error in compliance tests, added pip freeze for owl bot t…

c4c9976

…esting

merged from branch

60735ff

Fixed some failing compliance tests by reformatting

2612a70

Added UuidTest to compliance tests

5d3d850

merged main branch

a708987

Moved back sqlalchemy constraints to 1.4

a3a4ee6

Update testing/constraints-3.8.txt

a71e1ee

tswast commented Apr 2, 2024

View reviewed changes

tswast changed the title ~~feat: Support SQLAlchemy 2.0, raise minimum required version to 1.4.x~~ feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x Apr 2, 2024

tswast requested review from shollyman, chalmerlowe and Linchin and removed request for glasnt and alvarowolfx April 2, 2024 20:34

revert changelog

bcedd9c

tswast commented Apr 2, 2024

View reviewed changes

README.rst Outdated Show resolved Hide resolved

remove note

924003e

tswast commented Apr 2, 2024

View reviewed changes

tswast added 2 commits April 2, 2024 15:40

don't install prerelease in compliance session

dfbfcc3

sync owlbot

853e5fd

tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024

chalmerlowe requested changes Apr 3, 2024

View reviewed changes

tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py Outdated Show resolved Hide resolved

Update tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py

b8fd194

chalmerlowe reviewed Apr 3, 2024

View reviewed changes

chalmerlowe requested changes Apr 3, 2024

View reviewed changes

chalmerlowe self-assigned this Apr 3, 2024

make results order not matter

eda4813

tswast requested a review from chalmerlowe April 3, 2024 17:20

🦉 Updates from OwlBot post-processor

82c372a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chalmerlowe approved these changes Apr 3, 2024

View reviewed changes

chalmerlowe merged commit 7a4c3c2 into main Apr 3, 2024
17 checks passed

chalmerlowe deleted the development-build-v1.11.0.dev3 branch April 3, 2024 18:33

release-please bot mentioned this pull request Apr 3, 2024

chore(main): release 1.11.0 #1054

Merged

bnaul added a commit to replicahq/pybigquery that referenced this pull request Apr 5, 2024

Revert "feat: support SQLAlchemy 2.0, raise minimum required version …

1490a8a

…to 1.4.x (googleapis#1053)" This reverts commit 7a4c3c2.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x #1053

feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x #1053

tswast commented Apr 2, 2024 •

edited

Loading

tswast Apr 2, 2024

tswast Apr 2, 2024

chalmerlowe left a comment

chalmerlowe Apr 3, 2024

tswast Apr 3, 2024

chalmerlowe Apr 3, 2024

tswast Apr 3, 2024

chalmerlowe left a comment

chalmerlowe commented Apr 3, 2024 •

edited

Loading

chalmerlowe left a comment

		@@ -13,6 +13,30 @@ Older versions of this project were distributed as [pybigquery][0].

		[2]: https://pypi.org/project/pybigquery/#history

		## [1.11.0.dev3](https://github.com/googleapis/python-bigquery-sqlalchemy/compare/v1.9.0...v1.11.0.dev3) (2024-02-20)

	session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16,<2.1")
	session.install("--pre", "--no-deps", "--upgrade", "sqlalchemy>=1.4.16")

feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x #1053

feat: support SQLAlchemy 2.0, raise minimum required version to 1.4.x #1053

Conversation

tswast commented Apr 2, 2024 • edited Loading

tswast Apr 2, 2024

Choose a reason for hiding this comment

tswast Apr 2, 2024

Choose a reason for hiding this comment

chalmerlowe left a comment

Choose a reason for hiding this comment

chalmerlowe Apr 3, 2024

Choose a reason for hiding this comment

tswast Apr 3, 2024

Choose a reason for hiding this comment

chalmerlowe Apr 3, 2024

Choose a reason for hiding this comment

tswast Apr 3, 2024

Choose a reason for hiding this comment

chalmerlowe left a comment

Choose a reason for hiding this comment

chalmerlowe commented Apr 3, 2024 • edited Loading

chalmerlowe left a comment

Choose a reason for hiding this comment

tswast commented Apr 2, 2024 •

edited

Loading

chalmerlowe commented Apr 3, 2024 •

edited

Loading