Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CFF2 export #44

Merged
merged 29 commits into from
Jul 15, 2024
Merged

Implement CFF2 export #44

merged 29 commits into from
Jul 15, 2024

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Jul 12, 2024 •
edited
Loading

This fixes #42.

TODO:

  • apply subroutining.

@justvanrossum
Rename var/attr to be more explicit
9ebbd2e
@justvanrossum
Prepare for charstrings
266bec7
@justvanrossum
Improve type checking, make Builder a dataclass
46c442c
@justvanrossum
Make Builder only take keyword args
50725b8
@justvanrossum
Prepare for CFF2
46362ab
@justvanrossum
Parametrize output format
758e462
@justvanrossum
Factor out TTF glyph builder
93f29fc
@justvanrossum
Implement CFF2 export
3732758
@justvanrossum
Factor out the CFF var data hard bits
bf24754
@justvanrossum
whitespace
90245b0
@justvanrossum
Fix bounds pen usage: for CFF2 we need tight bounds, for TTF control …
bd3dee0 
…bounds
@justvanrossum
Fiddle
263d44b
@justvanrossum
Do subroutinization
27708b1
@justvanrossum
Adjust expected output to subroutinization
aa699e6
@justvanrossum
Ignore cffsubr for type checking
30a9b88
@justvanrossum
Fix type annotation
bd0fdf9
@justvanrossum
Also test otf export via fontra-workflow
080b14b
@justvanrossum
Fold two operations into one func
7f56124
@justvanrossum
Ensure we use a model that has the default source as the first item
48b5366
@justvanrossum
Test that our CFF2CharStringMergePen source order fix is effective
b87d94b
@justvanrossum
Simplify by not repeating condition
24aaaf6
@justvanrossum
Also test random glyph source order for ttf output
3c73ea1
@justvanrossum
Simplify explainer comment
ed34d8c
@justvanrossum
Generalize helper func, because who knows
f08bf1e
@justvanrossum
Work around fonttools issue with PointToSegmentPen
8def733
@justvanrossum
Add tiny subset of Noto Sans CJK VarCo to test edge case in otf export
e06ad24
@justvanrossum
Explain the need for this test case
8bbb973
@justvanrossum
Factor out computation of LSB
a82fae4
@justvanrossum
Move helper func
a9e9bcc
@justvanrossum justvanrossum merged commit 62144d2 into main Jul 15, 2024
4 checks passed
@justvanrossum justvanrossum deleted the cff-varc branch July 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CFF2 export
1 participant
@justvanrossum