Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user editable status definitions #184

Merged
merged 9 commits into from
May 29, 2024
Merged

Add support for user editable status definitions #184

merged 9 commits into from
May 29, 2024

Conversation

ollimeier
Copy link
Collaborator

Fixes #183

I have also tested it with converting an existing file:
fontra-copy XXX.fontra XXX.rcjk

  • opening the .rcjk-file with fontra
  • adding a new status definition
  • set a glyph source to the new status color code
  • close everything
  • open it again and have a look if everything is still there -> it works for me.

@ollimeier ollimeier requested a review from justvanrossum May 29, 2024 12:44
justvanrossum
justvanrossum reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think this is entirely correct.

There is a similar change to be made in backend_mysql.py:

  • xxx | standardCustomDataItems

to

  • standardCustomDataItems | xxx

@ollimeier ollimeier marked this pull request as ready for review May 29, 2024 14:35
@justvanrossum justvanrossum merged commit 75dec32 into main May 29, 2024
5 checks passed
@justvanrossum justvanrossum deleted the issue-183-user-editable-status-definitions branch May 29, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justvanrossum justvanrossum justvanrossum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt to user-editable status definitions
2 participants
@ollimeier @justvanrossum